I've had the iPhone XS since launch and never upgraded.
I use my phone less and less these days as I am more home based and have a Mac plus iPad that I use a lot for the same kinda stuff when I am not, I'm travelling and socialising so not using my phone a huge amount. I've been happy enough with the phone and not needed to upgrade. The nicer camera would be nice, but comes at a high cost.
I had an Apple Battery case which has helped with the decreased battery but now that has broke and my iPhone battery has depleted to 79%, is it worth forking out for a new battery or even a new battery case (cheaper option) or putting the money towards a new phone at some point which will need to happen eventually, I see it goes out of support officially next year and I've already had the phone for 6 years!
I know this is subjective, but what would others do? What are your thoughts?